Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 1.4.0-beta.0 #847

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 29, 2024

Link to #553

@ivanvc
Copy link
Member

ivanvc commented Oct 29, 2024

Sorry about the robustness failure. It's due to a prow infra current limitation, I'm aware and tracking it.

Should we add a note regarding Go 1.23.2? I see that previous releases did mention the Go version used (#836).

@ahrtr ahrtr force-pushed the changelog_20241029 branch from a6db331 to 2709ffc Compare October 29, 2024 15:51
@k8s-ci-robot
Copy link

@ahrtr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-bbolt-robustness-arm64 2709ffc link false /test pull-bbolt-robustness-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ahrtr
Copy link
Member Author

ahrtr commented Oct 29, 2024

Should we add a note regarding Go 1.23.2? I see that previous releases did mention the Go version used (#836).

Thanks for the reminder. Updated the changelog to only mention that it requires 1.23.x. bbolt is used as a library, it's up to users/application to decide the exact go version. We just need to clear call out the minor go version.

It's due to a prow infra current limitation, I'm aware and tracking it.

Thanks. If it needs a long time to resolve the issue (i.e. > 2 months), can we add it back to github for now (without arm64)?

@ivanvc
Copy link
Member

ivanvc commented Oct 29, 2024

Thanks. If it needs a long time to resolve the issue (i.e. > 2 months), can we add it back to github for now (without arm64)?

PTAL at kubernetes/test-infra#33735. I say let's hold them to avoid the noise. Restoring them should be quick.

Signed-off-by: Benjamin Wang <[email protected]>
@ahrtr ahrtr force-pushed the changelog_20241029 branch from 2709ffc to 1a4cb44 Compare October 29, 2024 18:24
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ahrtr.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member Author

ahrtr commented Oct 30, 2024

cc @fuweid @jmhbnz @serathius @tjungblu for awareness

@ahrtr ahrtr merged commit fc03e5c into etcd-io:main Nov 4, 2024
15 checks passed
@ahrtr ahrtr deleted the changelog_20241029 branch November 4, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants